Skip to content

Commit

Permalink
Look how they shine for you, and all the code that youuu miss ✨
Browse files Browse the repository at this point in the history
Signed-off-by: schristoff <[email protected]>
  • Loading branch information
schristoff committed Nov 28, 2023
1 parent da90ff0 commit f731b96
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions pkg/manifest/manifest.go
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ type SharingCriteria struct {
// - none: The dependency cannot be shared, even within the same dependency graph.
// - group: The dependency is shared with other bundles who defined the dependency
// with the same sharing group. This is the default mode.
Mode string `yaml:"mode"`
Mode bool `yaml:"mode"`

// Group defines matching criteria for determining if two dependencies are in the same sharing group.
Group SharingGroup `yaml:"group,omitempty"`
Expand All @@ -816,11 +816,7 @@ type SharingCriteria struct {
// GetEffectiveMode returns the mode, taking into account the default value when
// no mode is specified.
func (s SharingCriteria) GetEffectiveMode() bool {
if s.Mode == "" {
return false
}

return true
return s.Mode
}

// SharingGroup defines a set of characteristics for sharing a dependency with
Expand Down

0 comments on commit f731b96

Please sign in to comment.