Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters and Outputs do not have a default type #1691

Closed
carolynvs opened this issue Jul 27, 2021 · 1 comment · Fixed by #1692
Closed

Parameters and Outputs do not have a default type #1691

carolynvs opened this issue Jul 27, 2021 · 1 comment · Fixed by #1692
Assignees
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry!

Comments

@carolynvs
Copy link
Member

Describe the bug

When a type is not declared for a parameter or output, our new validation of its jsonschema fails (because it doesn't have a default type).

To Reproduce

  1. Create a bundle with a parameter or output and omit the type field.
  2. Install the bundle.

Expected behavior

Either the bundle should fail to build, OR porter should default the type to something sensible such as string.

Porter Command and Output

$ porter install -c hello-keyvault hello-keyvault
<TRUNCATED OUTPUT>
execution completed successfully!
Error: 1 error occurred:
        * error: [Getting a single type errored with "this schema has multiple types: <nil>" and getting multiple types errored with "this schema does not have multiple types: <nil>" Getting a single type errored with "this schema has multiple types: <nil>" and getting multiple types errored with "this schema does not have multiple types: <nil>"]

Version

v0.38.4

@carolynvs carolynvs added the bug Oops, sorry! label Jul 27, 2021
@carolynvs
Copy link
Member Author

I am going to try defaulting the type to string (unless there is a path specified, then I'll default it to file) and see how that goes.

@carolynvs carolynvs self-assigned this Jul 27, 2021
@carolynvs carolynvs added the 1 - 🍫 Eat chocolate _after_ emergency donuts label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant