Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porter parameters/credentials apply ignores the schemaType #2269

Closed
jasmdk opened this issue Jul 30, 2022 · 1 comment · Fixed by #2428
Closed

porter parameters/credentials apply ignores the schemaType #2269

jasmdk opened this issue Jul 30, 2022 · 1 comment · Fixed by #2428
Assignees
Labels
2 - 🍕 Pizza should be eaten daily gap We missed a spot v1.1.0

Comments

@jasmdk
Copy link
Contributor

jasmdk commented Jul 30, 2022

Describe the bug

It is possible to create a ParameterSet as a YAML file and apply it as a CredentialSet and the other way around. I would expect porter to complain as the schemaType does not match.

To Reproduce

Steps to reproduce the behavior:

  1. Run porter parameters create myparams.yaml
  2. See creating porter parameter set in the current directory
  3. Run porter credentials apply myparams.yaml
  4. See error: Applied NAMESPACE/NAME credential set
  5. Or run porter credentials create mycreds.yaml
  6. See creating porter credential set in the current directory
  7. Run porter parameters apply mycreds.yaml
  8. See error: Applied NAMESPACE/NAME parameter set

Expected behavior

Porter should abort, stating that a CredentialSet can not be applied as a ParameterSet and the other way around.

Porter Command and Output

See above

Version

porter v1.0.0-beta.1 (eaf8d0d)

@jasmdk jasmdk added the bug Oops, sorry! label Jul 30, 2022
@carolynvs
Copy link
Member

That field was originally intended just to help us out later when implementing support for VS Code autocomplete, but yeah we can totally check for if the schemaType is set (it's optional) and then validate it.

@carolynvs carolynvs added gap We missed a spot 2 - 🍕 Pizza should be eaten daily and removed bug Oops, sorry! labels Aug 1, 2022
@carolynvs carolynvs self-assigned this Sep 9, 2022
@carolynvs carolynvs moved this to In Progress in Upcoming Releases Sep 9, 2022
@github-project-automation github-project-automation bot moved this from In Progress to Done in Upcoming Releases Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - 🍕 Pizza should be eaten daily gap We missed a spot v1.1.0
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants