Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fails when schemaType is set in porter.yaml #2348

Closed
carolynvs opened this issue Sep 9, 2022 · 1 comment · Fixed by #2428
Closed

build fails when schemaType is set in porter.yaml #2348

carolynvs opened this issue Sep 9, 2022 · 1 comment · Fixed by #2428
Assignees
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry! v1.1.0

Comments

@carolynvs
Copy link
Member

carolynvs commented Sep 9, 2022

We documented that schemaType was supported for the porter manifest, see https://getporter.org/bundle/manifest/file-format/#example, but when you actually set it, porter fails to validate the manifest because it's an unexpected field.

$ porter build
Using buildkit build driver
unsupported property set or a custom action is defined incorrectly: error unmarshaling custom action schemaType: yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `Bundle` into manifest.Steps

This is on porter v1.0.0-rc.1

Reproduction Steps:

  1. Run porter create
  2. Edit the bundle and include schemaType: Bundle at the top
  3. Run porter build
@carolynvs carolynvs added bug Oops, sorry! 1 - 🍫 Eat chocolate _after_ emergency donuts labels Sep 9, 2022
@carolynvs carolynvs self-assigned this Sep 9, 2022
@carolynvs
Copy link
Member Author

For the v1.0.0 release, I'll fix the docs so that people know that schemaType isn't supported on porter.yaml. Then in a patch release post v1, we'll fix this along with #2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🍫 Eat chocolate _after_ emergency donuts bug Oops, sorry! v1.1.0
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant