Bump cnab-go to v0.20.0 #1611
Merged
Bump cnab-go to v0.20.0 #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 So excited! We need to update or remove the cnab-go dependency override here right? |
* jsonschema-lock is finally merged and we can get rid of our fork * Allow numbers in bundle.json again * Add support for params of type array * Add ValidateSchema function * Add output validation * Validate parameter defaults * Validate param regardless of if override or default * Fix retrieval of outputs when characters in the result id are in the output name * Add support for params of object type in ConvertValue (getporter#251) * Use alternate canonical json library * Bump docker libraries to newer version Signed-off-by: Carolyn Van Slyck <[email protected]>
|
Oops, it would have helped if all my changes were pushed. I've squashed and force pushed. |
carolynvs
commented
Jun 3, 2021
| @@ -99,7 +99,8 @@ | |||
| }, | |||
| "definitions": { | |||
| "connstr": { | |||
| "type": "string" | |||
| "type": "string", | |||
There was a problem hiding this comment.
Now that you validate default values, the test started failing because this didn't have a default.
vdice
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big bump energy
output name