Update bundle action commands to work with the installation record #1724
+527
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
actions-edit-installation-record
branch
2 times, most recently
from
53cd8fe to
82994a9
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carolynvs
force-pushed
the
actions-edit-installation-record
branch
2 times, most recently
from
84c7924 to
3033511
Compare
We want to be able to compare the bundle digest provided during install with the digest of the bundle in the cache. Signed-off-by: Carolyn Van Slyck <[email protected]>
1. Persist additional installation metadata on install * bundle digest * bundle version * user-specified parameters * names of parameter and credential sets 2. Support changing the bundle version with upgrade --version 3. Update invoke and uninstall to use an installation record. Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
actions-edit-installation-record
branch
from
3033511 to
fafa39e
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vdice
approved these changes
Aug 27, 2021
| @@ -8,7 +8,7 @@ import ( | |||
|
|
|||
| type BundlePullOptions struct { | |||
| Reference string | |||
| ref cnab.OCIReference | |||
| _ref *cnab.OCIReference | |||
There was a problem hiding this comment.
Curious as to the _* naming convention for this field? I'm anticipating this is Golang knowledge I need to acquire :)
There was a problem hiding this comment.
I was stealing from python's naming convention. Fields with an underscore shouldn't be used outside of the struct's own methods. It's just a way to indicate, hey if you found this via autocomplete, you probably shouldn't be using it.
It's a fake private field essentially since there's only exported/unexported at the package level but no concept of private. It really was just to help me refactor and not accidentally use it (since I was using that field elsewhere in the package previously).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Update bundle action commands to work with the installation record
Install now persists extra information to the installation record. The others, invoke, upgrade and uninstall all now load up the record and have the action work against that. Upgrade also now supports
porter upgrade INSTALLATION --version. It will handle updating the installation to the desired version and then executing the bundle to get to that version.Add ExtendedBundle Wrapper
This wraps the cnab-go bundle and adds support for custom extensions that porter supports. It will help us wean off of using the porter manifest at runtime, which is a huge problem because then our support for spec extensions only works when it was authored in Porter.
More work is needed to fix this, but this is just a refactoring to get the data in the right place, i.e. when we do pass around a bundle, it's a bundle that knows how to deal with extensions.
I am still saving a cnab bundle document so that if we change the structure of the wrapper it doesn't impact the stored document.
Include bundle reference and digest in the cache
We want to be able to compare the bundle digest provided during install with the digest of the bundle in the cache.
What issue does it fix
This is part of supporting a reconcile command in porter.
Notes for the reviewer
Checklist