Add ExtendedBundle wrapper #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
extended-bundle-wrapper
branch
from
4c3ad07 to
fb58b9f
Compare
carolynvs
commented
Aug 25, 2021
| @@ -303,6 +303,9 @@ func validateCredentialName(args []string) error { | |||
|
|
|||
| func (p *Porter) CredentialsApply(o ApplyOptions) error { | |||
| namespace, err := p.getNamespaceFromFile(o) | |||
| if err != nil { | |||
carolynvs
force-pushed
the
extended-bundle-wrapper
branch
from
fb58b9f to
dd46a93
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This wraps the cnab-go bundle and adds support for custom extensions that porter supports. It will help us wean off of using the porter manifest at runtime, which is a huge problem because then our support for spec extensions only works when it was authored in Porter. More work is needed to fix this, but this is just a refactoring to get the data in the right place, i.e. when we do pass around a bundle, it's a bundle that knows how to deal with extensions. I am still saving a cnab bundle document so that if we change the structure of the wrapper it doesn't impact the stored document. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
extended-bundle-wrapper
branch
from
dd46a93 to
101377b
Compare
3 tasks
Signed-off-by: Carolyn Van Slyck <[email protected]>
vdice
approved these changes
Aug 26, 2021
pkg/cnab/dependencies.go
Outdated
| } | ||
|
|
||
| // DependencyReader is a Reader for the DependenciesExtension, which reads | ||
| // from the applicable section in the provided bundle and returns a the raw |
There was a problem hiding this comment.
Suggested change
| // from the applicable section in the provided bundle and returns a the raw | |
| // from the applicable section in the provided bundle and returns the raw |
Looks like there are other spots where this typo exists, in other files. To the search and replace!
pkg/cnab/file_parameter.go
Outdated
| } | ||
|
|
||
| // FileParameterReader is a Reader for the FileParameterExtension. | ||
| // The extension does not have any data, it's presence indicates that |
There was a problem hiding this comment.
Suggested change
| // The extension does not have any data, it's presence indicates that | |
| // The extension does not have any data, its presence indicates that |
Signed-off-by: Carolyn Van Slyck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
This wraps the cnab-go bundle and adds support for custom extensions that porter supports. It will help us wean off of using the porter manifest at runtime, which is a huge problem because then our support for spec extensions only works when it was authored in Porter.
More work is needed to fix this, but this is just a refactoring to get the data in the right place, i.e. when we do pass around a bundle, it's a bundle that knows how to deal with extensions.
I am still saving a cnab bundle document so that if we change the structure of the wrapper it doesn't impact the stored document.
What issue does it fix
Chipping away at the root cause of #1024. We need to get to a place where the porter.yaml is only used to generate the bundle, and to pass off actions/config to the mixins. We shouldn't be using it in the porter runtime (where we decide if file parameters should be supported for example, or parse dependencies), and should be acting off the bundle.json entirely.
Notes for the reviewer
Sorry for all the refactoring lately! 😬
Checklist