Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide internal outputs from porter installation outputs list #1761

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

carolynvs
Copy link
Member

What does this change

Do not include internal outputs, such as porter-state.tgz when listing outputs.

What issue does it fix

We don't want to expose internals in our commands like explain, and listing outputs.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

Do not include internal outputs, such as porter-state.tgz when listing
outputs.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs force-pushed the hide-internal-outputs branch from 181b70b to 3864352 Compare September 15, 2021 22:06
@carolynvs carolynvs marked this pull request as ready for review September 15, 2021 22:06
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@carolynvs carolynvs merged commit 09840b4 into getporter:release/v1 Sep 17, 2021
@carolynvs carolynvs deleted the hide-internal-outputs branch September 17, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants