Sync main into release/v1 #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update helm3 mixin doc Document how to specify multiple values. close MChorfa/porter-helm3#24 Signed-off-by: Mohamed Chorfa <[email protected]>
When we parse outputs for jsonPath expressions, numbers are not being formatted as expected. For example, a number like "123123123" is being output as "1.23123123e+08". This is due to how we are parsing the jsonPath. The output is marshaled into a generic map, where json numbers are represented as float64. We use fmt.Sprintf to format the matching output value, and Go by default formats float with %f/%g, neither of which is the desired format. I've updated our json parsing to use the Number type so that the format of the captured value matches what was used in the original output. Signed-off-by: Carolyn Van Slyck <[email protected]>
Helm2 is deprecated and the example doesn't work anymore because of that. Switch to the helm3 mixin. Signed-off-by: Carolyn Van Slyck <[email protected]>
Properly format numbers parsed from jsonPath outputs
Use helm3 for the airgap example
When we build the example bundles, they rely on some mixins being installed on the CI machine. In a recent PR, I updated an example to use the helm3 mixin since the old helm mixin is deprecated. I forgot to update the mixins installed in CI, so the example mixin build is failing. This should fix that. Signed-off-by: Carolyn Van Slyck <[email protected]>
…during-build Install the helm3 mixin on CI machine
* Announce v1.0.0-alpha.3 Add a blog post announcing the v1.0.0-alpha.3 prerelease, highlighting key features and explaining how to install it safely. Signed-off-by: Carolyn Van Slyck <[email protected]> * Fix twitter card Signed-off-by: Carolyn Van Slyck <[email protected]> * Review feedback Signed-off-by: Carolyn Van Slyck <[email protected]>
In order to completely switch over to helm3 we need one more feature in the helm3 mixin, --create-namespace, since our unit tests rely on that. So I'm adding it back for now to get the tests passing. Signed-off-by: Carolyn Van Slyck <[email protected]>
Continue installing the helm2 mixin
Update all usages of the old helm2 mixin to helm3. I did not change the default mixin installed with Porter because we are avoiding all breaking changes on v0.38 and this would count as a breaking change, even though no one should be using helm2 anymore. Signed-off-by: Carolyn Van Slyck <[email protected]>
This was a debug print statement that I meant to just add while fixing something locally. It shouldn't be printed every time you run a bundle! Signed-off-by: Carolyn Van Slyck <[email protected]>
Remove debug print statement
With the helm3 mixin using --atomic, helm is waiting for the deployment to be considered complete. However when installing on kind, the default service type of loadbalancer will never get an ip address assigned. I've changed the service type to NodePort so that the helm release completes successfully and doesn't just timeout waiting for an ip that is never coming. Signed-off-by: Carolyn Van Slyck <[email protected]>
Only give permission to the current user, never to the group or other. Only mixins/plugins and scripts should be executable. When porter accesses files, it checks that there aren't any credentials/parameteres/claims with wide-open permissions. This check is skipped on Windows because files by default are not shared, and Go can't accurately report file permissions on Windows. $ porter --debug list --debug-plugins Resolved porter binary from /usr/local/bin/porter to /Users/carolynvs/.porter/porter Resolved storage plugin to storage.porter.filesystem /Users/carolynvs/.porter/porter plugin run storage.porter.filesystem PORTER HOME: /Users/carolynvs/.porter Checking file permissions in /Users/carolynvs/.porter Error: could not list installations: could not read storage schema document: incorrect file permissions on /Users/carolynvs/.porter/config.toml, it should be 600. Correct it manually or by running porter storage fix-permissions. $ porter storage fix-permissions Resetting file permissions in /Users/carolynvs/.porter... $ porter --debug list --debug-plugins Resolved porter binary from /usr/local/bin/porter to /Users/carolynvs/.porter/porter Resolved storage plugin to storage.porter.filesystem /Users/carolynvs/.porter/porter plugin run storage.porter.filesystem Checking file permissions in /Users/carolynvs/.porter NAME CREATED MODIFIED LAST ACTION LAST STATUS bug 2021-09-20 2021-09-20 install succeeded porter-hello 2021-09-20 2021-09-20 install failed whalegap 2021-09-14 2021-09-14 install succeeded mas-whales 2021-09-14 2021-09-14 install failed mybuns 2021-08-10 2021-08-10 install succeeded spike-helm3-mysql 2021-08-02 2021-08-02 install succeeded helm3-mysql 2021-07-29 2021-07-29 install succeeded hello-keyvault 2021-07-27 2021-07-27 install succeeded helm-mysql 2021-06-30 2021-06-30 install succeeded tmp 2021-06-30 2021-06-30 upgrade succeeded credentials-tutorial 2021-06-29 2021-06-29 install succeeded porterops 2021-06-10 2021-06-10 install succeeded kubernetes 2020-08-24 2020-08-24 install succeeded HELLO 2020-08-17 2020-08-17 uninstall succeeded Signed-off-by: Carolyn Van Slyck <[email protected]>
Now that helm runs with --atomic it became painfully clear that we weren't passing the username/password for mysql correctly through the wordpress test bundle. This fixes the wiring between the two bundles so that wordpress connects to the db created by its dependency. Signed-off-by: Carolyn Van Slyck <[email protected]>
Use the helm3 mixin everywhere
Lock down file permissions
Add a flag to the bundle actions allowing the user to skip saving a copy of the logs to Porter's datastore. porter install --no-logs Now when they run porter logs -i mybuns, it will return "no logs found". This is useful in cases where the logs are too large to store. Signed-off-by: Carolyn Van Slyck <[email protected]>
Make log persistence configurable
I went through our top broken links on Netlify Analytics and fixed them. Signed-off-by: Carolyn Van Slyck <[email protected]>
* Blog about the helm3 v0.1.14 mixin release Explain the latest release and why Porter moved to it immediately. Signed-off-by: Carolyn Van Slyck <[email protected]> * Include notes for the v0.1.15 release Signed-off-by: Carolyn Van Slyck <[email protected]>
Fix broken links
Signed-off-by: Mohamed Chorfa <[email protected]>
update helm3 mixin documentation to the latest release
Signed-off-by: Carolyn Van Slyck <[email protected]>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The changes to how we run the wordpress bundle has exposed a bug in running dependencies that was introduced in v1. We weren't resolving parameters for dependencies and were only passing in the specified params from the command line or bundle overrides. Signed-off-by: Carolyn Van Slyck <[email protected]>
|
/azp run porter-integration |
|
Pull request contains merge conflicts. |
vdice
approved these changes
Oct 5, 2021
Signed-off-by: Carolyn Van Slyck <[email protected]>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge recent changes on main into the release/v1 branch