Fix branch deploy #1833
Merged
Fix branch deploy #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix how the root url is calculated for branch deploys, so that it keeps the special branch subdomain. e.g. release-v1.porter.sh instead of release-v1--porter.netlify.app Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
requested review from
iennae
and removed request for
jeremyrickard
vdice
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fix how the root url is calculated for branch deploys, so that it keeps the special branch subdomain.
e.g. release-v1.porter.sh instead of release-v1--porter.netlify.app
What issue does it fix
A lot of the links on the porter website are absolute (for reasons). This meant that on the https://release-v1.porter.sh website some links (like the top level navigation) were all sending the user to https://release-v1--porter.netlify.app which is confusing.
This will keep the user on the same domain while using the v1 prerelease site.
Notes for the reviewer
This was tested out here: https://test.porter.sh, note that the links in the top nav stay on the same domain now.
Checklist