Fix GetBuilder #1835
Merged
Fix GetBuilder #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
fix-get-builder
branch
2 times, most recently
from
fa1aacf to
3474651
Compare
I accidentally tried to use a fallthrough, which go doesn't support. I have fixed GetBuilder and added a unit test to validate that it is creating a build driver for all cases. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
fix-get-builder
branch
from
3474651 to
f137e59
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vdice
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
I accidentally tried to use a fallthrough, which go doesn't support. I
have fixed GetBuilder and added a unit test to validate that it is
creating a build driver for all cases.
What issue does it fix
Fixes regression from #1825
Notes for the reviewer
Sorry I didn't catch this in the PR!
Checklist