Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back lost docker network logic to magefile #1866

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

carolynvs
Copy link
Member

What does this change

I accidentally committed changes to the magefile that broke
connectivity between the test kind cluster and the local registry
running in docker. They need to be on the same network.

This adds back code that I thought wasn't needed anymore to get docker
pulls from localhost:5000 from inside the cluster working again.

What issue does it fix

It fixes pulling images locally when using KIND to develop the operator

Notes for the reviewer

Nope

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

I accidentally committed changes to the magefile that broke
connectivitiy between the test kind cluster and the local registry
running in docker. They need to be on the same network.

This adds back code that I thought wasn't needed anymore to get docker
pulls from localhost:5000 from inside the cluster working again.

Signed-off-by: Carolyn Van Slyck <[email protected]>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- would this affect the integration tests? Should we kick off a run?

@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs merged commit fb15bd9 into getporter:release/v1 Jan 25, 2022
@carolynvs carolynvs deleted the fix-local-registry branch January 25, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants