Consolidate rootLogger and scopedLogger #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By only allowing the porter application context to create a root span, we can consolidate rootlogger and scoped logger into a single TraceLogger, and simplify logic around setting attributes on the root span. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
do-not-use-root-logger
branch
from
618c73c to
2d684e0
Compare
Sometimes the stack looks like this when we ask for the calling function
name:
InstallBundle
-> tracing.TraceLogger.StartSpan
-> tracing.callerFunc
other times it looks like this
ExecuteBundle
-> tracing.StartSpan
-> tracing.TraceLogger.StartSpan
-> tracing.callerFunc
So I have tweaked how we look up the stack to keep checking until we
find a function that isn't in the tracing package
Signed-off-by: Carolyn Van Slyck <[email protected]>
|
I noticed when working on this that callerFunc is returning funny names when the function had a pointer receiver. So for @VinozzZ can you take a look after this PR is merged? (After because I edited the same file in this PR) |
Signed-off-by: Carolyn Van Slyck <[email protected]>
VinozzZ
approved these changes
Jan 28, 2022
|
@VinozzZ Thanks for pushing me to clean up the tracing package! 🙇♀️ |
joshuabezaleel
pushed a commit
to joshuabezaleel/porter
that referenced
this pull request
Feb 8, 2022
* Consolidate rootLogger and scopedLogger By only allowing the porter application context to create a root span, we can consolidate rootlogger and scoped logger into a single TraceLogger, and simplify logic around setting attributes on the root span. Signed-off-by: Carolyn Van Slyck <[email protected]> * Allow for a variable stack size when finding the function name Sometimes the stack looks like this when we ask for the calling function name: InstallBundle -> tracing.TraceLogger.StartSpan -> tracing.callerFunc other times it looks like this ExecuteBundle -> tracing.StartSpan -> tracing.TraceLogger.StartSpan -> tracing.callerFunc So I have tweaked how we look up the stack to keep checking until we find a function that isn't in the tracing package Signed-off-by: Carolyn Van Slyck <[email protected]> * Document more of the tracing package Signed-off-by: Carolyn Van Slyck <[email protected]> Signed-off-by: joshuabezaleel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
By only allowing the porter application context to create a root span,
we can consolidate rootlogger and scoped logger into a single
TraceLogger, and simplify logic around setting attributes on the root
span.
What issue does it fix
N/A
Notes for the reviewer
N/A
Checklist
Reviewer Checklist