Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mixin install target #1883

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Jan 31, 2022

What does this change

I was accidentally copying the mixin runtime binary into the wrong
directory under PORTER_HOME.

What issue does it fix

If a developer is using a mixin that was using v1.0.0-* for its magefile install target, then the runtime for the mixin wasn't dropped in the right place for it to be picked up during porter build. This affects: skeletor, docker-compose.

Notes for the reviewer

Oops 🤦‍♀️

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs carolynvs marked this pull request as ready for review January 31, 2022 19:56
@carolynvs carolynvs force-pushed the fix-mixin-install branch 2 times, most recently from 6afe02b to c3a1333 Compare January 31, 2022 21:09
@carolynvs carolynvs requested a review from VinozzZ January 31, 2022 21:13
I was accidentally copying the mixin runtime binary into the wrong
directory under PORTER_HOME.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs merged commit 40ae7e3 into getporter:release/v1 Feb 1, 2022
@carolynvs carolynvs deleted the fix-mixin-install branch February 1, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants