Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix close issue workflow #1965

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Conversation

carolynvs
Copy link
Member

What does this change

I have forked the close issue workflow and edited it to support the new pull_request_target event type. I have submitted PRs upstream to the original workflow but until they are merged we can use this build of the github action.

What issue does it fix

The close issue workflow only supports pull_request, which does not have permission to close issues when the pull request was created from a fork.

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

I have forked the close issue workflow and edited it to support the new
pull_request_target event type. I have submitted PRs upstream to the
original workflow but until they are merged we can use this build of the
github action.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs merged commit 4feb486 into getporter:release/v1 Mar 11, 2022
@carolynvs carolynvs deleted the fix-close-issue branch March 11, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant