Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cnab-go, Go, docker, containerd and k8s (on stable) #1971

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

carolynvs
Copy link
Member

What does this change

Update to the most recently patched versions of Go, docker, containerd, and k8s. The majority of these versions are actually resolved from cnab-go, so we don't need to maintain replace statements for them anymore! 🎉

What issue does it fix

Fixes #1942

Notes for the reviewer

This requires changes to cnab-go and cnab-to-oci, so that will take a bit to get those merged first them fix up the go.mod

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs carolynvs changed the title Bump cnab-go, Go, docker, containerd and k8s Bump cnab-go, Go, docker, containerd and k8s (on stable) Mar 15, 2022
Update to the most recently patched versions of cnab-go (stable fork),
cnab-to-oci,  Go, docker, containerd, and k8s. The majority of these versions are actually resolved from
cnab-go, so we don't need to maintain replace statements for them
anymore! 🎉

I'm staying on Go 1.16 for the go.mod format because go mod tidy can't
resolve the graph when it's set to go 1.17. On release/v1 we are happily
using the latest go.mod format so I'm not concerned that it's a long
term problem. We still build with Go 1.17, it's just the file format
that is impacted.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs requested a review from VinozzZ March 22, 2022 14:57
@carolynvs carolynvs marked this pull request as ready for review March 22, 2022 15:35
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my relatively naive view, these changes lgtm!

Thank you for adding comments about why go.mod was not advanced to 1.17.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs merged commit 55d92c0 into getporter:main Mar 22, 2022
@carolynvs carolynvs deleted the bump-cnab-go branch March 22, 2022 18:35
@carolynvs carolynvs mentioned this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade containerd on v0.38
3 participants