Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test and example bundles #1985

Merged
merged 4 commits into from
Mar 28, 2022

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Mar 28, 2022

What does this change

  • We have finished vetting using ghcr.io with Porter and it has been more
    stable than Docker Hub. So we are going to stop publishing our images
    and example bundles to Docker Hub and only publish to ghcr.io
    I will leave the old assets up at Docker Hub and they will continue to
    be available for the forseeable future.

  • Bump the version on the example bundles. We should have done this as
    soon as we cut a 1.0.0 release of Porter, since it ended up publishing
    examples over the top of existing ones that were compatible with v0.38

    Well it's too late to fix that, but we can make sure we bump the version
    number when we move to ghcr.io. Later we can optionally go back and
    republish the bundles from stable if needed (which will always host with
    docker hub, we aren't moving the old stable example bundles to ghcr.io)

  • Add an optional parameter to the hello bundle, along with an output for
    the name passed in, so that we can continue to use it as a test bundle
    for the operator. Testing with a bundle that doesn't have inputs/outputs
    managed to miss a number of key problems with the operator so this will
    be helpful.

  • Our test bundles shouldn't reference a real registry, it increases the
    change that we may accidentally push them to a live registry. Setting
    registry to localhost:5000 ensures that when we build/publish test
    bundles that they stay on your local machine.

What issue does it fix

Closes #1280

Notes for the reviewer

I recommend looking through this by commit instead of all at once. I've grouped related changes which should make it easier to get through this big PR.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs carolynvs force-pushed the publish-updated-examples branch 2 times, most recently from d3609bc to 0d36e0c Compare March 28, 2022 18:59
@carolynvs
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@carolynvs carolynvs force-pushed the publish-updated-examples branch from 891d88e to d49ed89 Compare March 28, 2022 20:10
We have finished vetting using ghcr.io with Porter and it has been more
stable than Docker Hub. So we are going to stop publishing our images
and example bundles to Docker Hub and only publish to ghcr.io

I will leave the old assets up at Docker Hub and they will continue to
be available for the forseeable future.

Signed-off-by: Carolyn Van Slyck <[email protected]>
Bump the version on the example bundles. We should have done this as
soon as we cut a 1.0.0 release of Porter, since it ended up publishing
examples over the top of existing ones that were compatible with v0.38

Well it's too late to fix that, but we can make sure we bump the version
number when we move to ghcr.io. Later we can optionally go back and
republish the bundles from stable if needed (which will always host with
docker hub, we aren't moving the old stable example bundles to ghcr.io)

Signed-off-by: Carolyn Van Slyck <[email protected]>
Add an optional parameter to the hello bundle, along with an output for
the name passed in, so that we can continue to use it as a test bundle
for the operator. Testing with a bundle that doesn't have inputs/outputs
managed to miss a number of key problems with the operator so this will
be helpful.

Signed-off-by: Carolyn Van Slyck <[email protected]>
Our test bundles shouldn't reference a real registry, it increases the
change that we may accidentally push them to a live registry. Setting
registry to localhost:5000 ensures that when we build/publish test
bundles that they stay on your local machine.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs force-pushed the publish-updated-examples branch from d49ed89 to 3b33003 Compare March 28, 2022 20:15
@carolynvs
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs marked this pull request as ready for review March 28, 2022 20:29
@carolynvs carolynvs requested a review from VinozzZ March 28, 2022 20:29
@carolynvs carolynvs merged commit 9bc5881 into getporter:release/v1 Mar 28, 2022
@carolynvs carolynvs deleted the publish-updated-examples branch March 28, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants