-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup test and example bundles #1985
Merged
carolynvs
merged 4 commits into
getporter:release/v1
from
carolynvs:publish-updated-examples
Mar 28, 2022
Merged
Cleanup test and example bundles #1985
carolynvs
merged 4 commits into
getporter:release/v1
from
carolynvs:publish-updated-examples
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3609bc
to
0d36e0c
Compare
/azp run test-porter-release |
Azure Pipelines failed to run 1 pipeline(s). |
891d88e
to
d49ed89
Compare
We have finished vetting using ghcr.io with Porter and it has been more stable than Docker Hub. So we are going to stop publishing our images and example bundles to Docker Hub and only publish to ghcr.io I will leave the old assets up at Docker Hub and they will continue to be available for the forseeable future. Signed-off-by: Carolyn Van Slyck <[email protected]>
Bump the version on the example bundles. We should have done this as soon as we cut a 1.0.0 release of Porter, since it ended up publishing examples over the top of existing ones that were compatible with v0.38 Well it's too late to fix that, but we can make sure we bump the version number when we move to ghcr.io. Later we can optionally go back and republish the bundles from stable if needed (which will always host with docker hub, we aren't moving the old stable example bundles to ghcr.io) Signed-off-by: Carolyn Van Slyck <[email protected]>
Add an optional parameter to the hello bundle, along with an output for the name passed in, so that we can continue to use it as a test bundle for the operator. Testing with a bundle that doesn't have inputs/outputs managed to miss a number of key problems with the operator so this will be helpful. Signed-off-by: Carolyn Van Slyck <[email protected]>
Our test bundles shouldn't reference a real registry, it increases the change that we may accidentally push them to a live registry. Setting registry to localhost:5000 ensures that when we build/publish test bundles that they stay on your local machine. Signed-off-by: Carolyn Van Slyck <[email protected]>
d49ed89
to
3b33003
Compare
/azp run test-porter-release |
Azure Pipelines successfully started running 1 pipeline(s). |
vdice
approved these changes
Mar 28, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
We have finished vetting using ghcr.io with Porter and it has been more
stable than Docker Hub. So we are going to stop publishing our images
and example bundles to Docker Hub and only publish to ghcr.io
I will leave the old assets up at Docker Hub and they will continue to
be available for the forseeable future.
Bump the version on the example bundles. We should have done this as
soon as we cut a 1.0.0 release of Porter, since it ended up publishing
examples over the top of existing ones that were compatible with v0.38
Well it's too late to fix that, but we can make sure we bump the version
number when we move to ghcr.io. Later we can optionally go back and
republish the bundles from stable if needed (which will always host with
docker hub, we aren't moving the old stable example bundles to ghcr.io)
Add an optional parameter to the hello bundle, along with an output for
the name passed in, so that we can continue to use it as a test bundle
for the operator. Testing with a bundle that doesn't have inputs/outputs
managed to miss a number of key problems with the operator so this will
be helpful.
Our test bundles shouldn't reference a real registry, it increases the
change that we may accidentally push them to a live registry. Setting
registry to localhost:5000 ensures that when we build/publish test
bundles that they stay on your local machine.
What issue does it fix
Closes #1280
Notes for the reviewer
I recommend looking through this by commit instead of all at once. I've grouped related changes which should make it easier to get through this big PR.
Checklist
Reviewer Checklist