Fix website BASEURL #2003
Merged
Fix website BASEURL #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had made a change earlier to netlify.toml and forgot to use export when setting BASEURL. So at the moment when you go to release-v1.porter.sh or a pull request preview, the navigation links at the top all redirect back to porter.sh instead of using the unique BASEURL specific for that PR/branch. I have moved the BASEURL logic into mage so that it's not as easy to break in the future (hopefully). Signed-off-by: Carolyn Van Slyck <[email protected]>
VinozzZ
approved these changes
Apr 4, 2022
vdice
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
I had made a change earlier to netlify.toml and forgot to use export when setting BASEURL. So at the moment when you go to release-v1.porter.sh or a pull request preview, the navigation links at the top all redirect back to porter.sh instead of using the unique BASEURL specific for that PR/branch.
I have moved the BASEURL logic into mage so that it's not as easy to break in the future (hopefully).
Note that in each preview, when you hover over the top nav links, they stay on the same domain
Branch Preview: https://fix-branch-deploys--porter.netlify.app/
PR Preview: https://deploy-preview-2003--porter.netlify.app/
What issue does it fix
Links at the top of release-v1.porter.sh go to pages on porter.sh instead of the v1 website links.
Notes for the reviewer
Checklist
Reviewer Checklist