Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runtime manifest log output debug messages #2005

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

carolynvs
Copy link
Member

What does this change

We shouldn't always be printing out log lines when executing the runtime manifest. Those were always intended to be debug lines and I just missed gating them with a Debug check.

This makes sure that they are only printed when --debug is speciifed and that they are printed to stderr.

What issue does it fix

I was running simple bundles and copying the output for our documentation and realize we are printing at the wrong level.

Notes for the reviewer

N/A

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

We shouldn't always be printing out log lines when executing the runtime
manifest. Those were always intended to be debug lines and I just missed
gating them with a Debug check.

This makes sure that they are only printed when --debug is specifed and
that they are printed to stderr.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs carolynvs marked this pull request as ready for review April 5, 2022 15:59
@carolynvs carolynvs requested a review from VinozzZ April 5, 2022 15:59
@carolynvs carolynvs merged commit dbea000 into getporter:release/v1 Apr 5, 2022
@carolynvs carolynvs deleted the debug-statements branch April 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants