Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil panic in integration test #2042

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Apr 27, 2022

What does this change

Sometimes in integration test, if a mongo instance can't be successfully created, the Close() would return a nil panic.
This PR changes to only call Close when we are sure mongo is running

What issue does it fix

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@carolynvs
Copy link
Member

Thanks!

@carolynvs carolynvs merged commit d885d2e into getporter:release/v1 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants