Backport Switch from StringSlice to StringArray (#1931) #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test for parameters with space Signed-off-by: Simpcyclassy <[email protected]> * add contributor Signed-off-by: Simpcyclassy <[email protected]> * handle bundle parameter escape Signed-off-by: Simpcyclassy <[email protected]> * update parameters documentation Signed-off-by: Simpcyclassy <[email protected]> * Merge branch 'release/v1' into parameter-space-error Signed-off-by: Simpcyclassy <[email protected]> * array to slice paramenter Signed-off-by: Simpcyclassy <[email protected]> * define params as array var Signed-off-by: Simpcyclassy <[email protected]> * add schema version to yaml file Signed-off-by: Simpcyclassy <[email protected]> * Help get PR merged * Run mage build to generate the cli command documentation to include the recent changes * Skip the failing test that was added. This PR has enough to fix the comma parsing, and a follow-up will fix this failing test for when a parameter has a space in it. Signed-off-by: Carolyn Van Slyck <[email protected]> * Fix merge conflicts with release/v1 Signed-off-by: Carolyn Van Slyck <[email protected]> Co-authored-by: Carolyn Van Slyck <[email protected]> Signed-off-by: Chioma Onyekpere <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
backport-stringarray-fix
branch
from
3be1947 to
9b9f8a1
Compare
vdice
approved these changes
Apr 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1931 to the v0.38 stable release.