Rename claims to installations #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
rename-claims-to-installations
branch
from
4ba3878 to
baf5263
Compare
4 tasks
In v1 we stopped storing claims directly, which are runtime documents passed to bundles representing the current action. Instead we now store documents that better represent the installation, and a run of a bundle, using terms that we use in Porter, and not CNAB terms that were kind of misapplied over time as we evolved the data we stored. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
rename-claims-to-installations
branch
from
baf5263 to
71e8234
Compare
VinozzZ
approved these changes
May 6, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
In v1 we stopped storing claims directly, which are runtime documents passed to bundles representing the current action. Instead we now store documents that better represent the installation, and a run of a bundle, using terms that we use in Porter, and not CNAB terms that were kind of misapplied over time as we evolved the data we stored.
What issue does it fix
This is follow-up based on conversations with @VinozzZ where we noted that the term claim doesn't make sense anymore in Porter.
Notes for the reviewer
This relies on the storage package consolidation from #2052.
Checklist
Reviewer Checklist