Fix enabling telemetry #2061
Merged
Fix enabling telemetry #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The if statement was inverted so we weren't ever using the tracer. * I was accidentally closing the tracer instead of ending the span in one spot. Signed-off-by: Carolyn Van Slyck <[email protected]>
VinozzZ
reviewed
May 6, 2022
| defer test.RunPorter("uninstall", "otel-jaeger", "--allow-docker-host-access") | ||
|
|
||
| // Wait until the collection should be up | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
I don't have a immediate solution in mind but this maybe flaky in some situations
There was a problem hiding this comment.
Agreed! I wanted to get something to test that it's working or not for now and if I come up with a better way I'll update the test.
I tried doing a net dial but that passes just fine and then later the trace setup fails because the otel service isn't 100% ready. I feel like the best fix would be to have the porter bundle that installs the otel collection have logic and wait until the collector is up.
VinozzZ
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
What issue does it fix
Fixing a regression caused by #2026 when I applied some review feedback and got the boolean logic flipflopped. I've added an integration test to verify that the tracer is a real one.
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
Reviewer Checklist