Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context passed when resolving secrets in config file #2068

Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented May 17, 2022

What does this change

I was passing the context incorrectly when resolving secrets in the config file. This caused the trace spans to not be nested properly.

Here's what it looks like now, note that the plugin spans are not shown under the span in Porter where we called the plugin:
Screen Shot 2022-05-17 at 7 05 13 PM

Here's what it looks like with the fix, now the spans are all nested in a way that matches the call graph
Screen Shot 2022-05-17 at 7 07 45 PM
:

What issue does it fix

The trace spans emitted when we load Porter's config file had the incorrect parent.

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

I was passing the context incorrectly when resolving secrets in the
config file. This caused the trace spans to not be nested properly.

Signed-off-by: Carolyn Van Slyck <[email protected]>
Co-authored-by: Yingrong Zhao <[email protected]>
@carolynvs carolynvs force-pushed the fix-context-hierarchy-during-load branch from 6b08440 to 672162e Compare May 17, 2022 18:23
@carolynvs carolynvs requested a review from VinozzZ May 18, 2022 20:24
@carolynvs carolynvs marked this pull request as ready for review May 19, 2022 14:57
@carolynvs carolynvs merged commit 23393bf into getporter:release/v1 May 19, 2022
@carolynvs carolynvs deleted the fix-context-hierarchy-during-load branch May 19, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants