Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blog post for the new secret plugin protocol #2121

Merged
merged 5 commits into from
Jun 1, 2022

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented May 31, 2022

What does this change

This PR adds a new blog post for the new secret plugin protocol

What issue does it fix

Closes #2093

Notes for the reviewer

This should only be merged after getporter/examples#10 is merged and the example bundle is published

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
docs/content/blog/persist-sensitive-data-safely.md Outdated Show resolved Hide resolved
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! I can't wait for us to announce your new security feature. 🚀

@carolynvs carolynvs changed the base branch from release/v1 to main June 1, 2022 17:06
@carolynvs carolynvs changed the base branch from main to release/v1 June 1, 2022 17:06
@carolynvs
Copy link
Member

@VinozzZ Sorry I didn't catch this sooner. Our website, porter.sh, is published from the main branch. So if we want to point people to https://porter.sh/blog/your-blog-post, this PR needs to be against the main branch.

There are two ways to fix this.

  1. Rebase your PR against main and then I'll merge that into main. Then in my next "sync" PR it will get copied into release/v1.
  2. Merge the PR as-is and you can submit another PR against main with a cherry-pick of this commit.

Which would you like to do?

VinozzZ added 5 commits June 1, 2022 14:31
Signed-off-by: Yingrong Zhao <[email protected]>
Signed-off-by: Yingrong Zhao <[email protected]>
Signed-off-by: Yingrong Zhao <[email protected]>
Signed-off-by: Yingrong Zhao <[email protected]>
@VinozzZ VinozzZ force-pushed the sensitive-data-blog branch from 6610c2a to efb26f3 Compare June 1, 2022 18:31
@VinozzZ VinozzZ changed the base branch from release/v1 to main June 1, 2022 18:33
@VinozzZ
Copy link
Contributor Author

VinozzZ commented Jun 1, 2022

@VinozzZ Sorry I didn't catch this sooner. Our website, porter.sh, is published from the main branch. So if we want to point people to https://porter.sh/blog/your-blog-post, this PR needs to be against the main branch.

There are two ways to fix this.

1. Rebase your PR against main and then I'll merge that into main. Then in my next "sync" PR it will get copied into release/v1.

2. Merge the PR as-is and you can submit another PR against main with a cherry-pick of this commit.

Which would you like to do?

I rebased it against main

@carolynvs carolynvs merged commit bc17350 into getporter:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain plugin changes in a blog post
2 participants