Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installation schema with correct dependency schema #2165

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

sgettys
Copy link
Contributor

@sgettys sgettys commented Jun 16, 2022

Signed-off-by: Steven Gettys [email protected]

What does this change

Update the dependency schema for v1 manifests

Notes for the reviewer

Extended the current schema unit test to validate a manifest that has dependencies defined in it

This is a breaking change for v1.0.0-alpha.20 and previous

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🙇‍♀️

@carolynvs carolynvs merged commit f8cb06c into getporter:release/v1 Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants