staticcheck lint fixes

[tchaudhry91]

What does this change

A bunch of staticcheck fixes that I felt were straightforward. Some maybe debatable and can be "ignored" or worked around. Those can be discussed in the PR.

What issue does it fix

#2081 - Incremental Progress

Notes for the reviewer

Some fairly straightforward things unchecked errors etc have been fixed. A couple of potential bugs as well (checking err instead of !ok).

Checklist

• Did you write tests?
• Did you write documentation?
• Did you change porter.yaml or a storage document record? Update the corresponding schema file.
• If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

• Comment with /azp run test-porter-release if a magefile or build script was modified
• Comment with /azp run porter-integration if it's a non-trivial PR

[carolynvs]

Looks good! I just have a couple small changes that need to be made and this is ready to merge.

[tchaudhry91]

@carolynvs completed changes as requested!

[carolynvs]

Thanks for cleaning up all the lint errors! This is really helpful and we can finally enforce no lint errors going forward in our builds. 💪

[tchaudhry91]

Hehe. Thanks @carolynvs but there are a few staticcheck fixes still left before we enforce lint in the CI. The remaining changes may require your input though or atleast I felt like there was something not totally straightforward with those.

[carolynvs]

@tchaudhry91 oops, I must have missed that. Are we tracking that problem in another issue or pull request?

[tchaudhry91]

@carolynvs we can track it in #2081 only. I'll update it with the remaining fixes.