Fix timing on logging a plugin connection error #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connecting to a plugin and it fails to connect, log the error first, and then call close on the connection. This ensures that the order of the error(s) in our log file/traces match the order the events happened. Otherwise it's easy to confuse the error from connect with any additional errors triggered by close, when they are logged out of order. This fixes the order of the errors being logged which should help with that. Signed-off-by: Carolyn Van Slyck <[email protected]>
vdice
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to a plugin and it fails to connect, log the error first, and then call close on the connection. This ensures that the order of the error(s) in our log file/traces match the order the events happened. Otherwise it's easy to confuse the error from connect with any additional errors triggered by close, when they are logged out of order.
This fixes the order of the errors being logged which should help with that.