Update error message when docker is not available #2217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Simple change to detect local docker availability and update error message.
The detection mechanism is currently just checking exit code of
docker info
. I suppose this is the most cross platform way of checking it? Open to suggestions on this.What issue does it fix
Closes #2066
Notes for the reviewer
I'm not sure I can write a test for this? Ideally, the test could stop docker on the system and test the error message, however, that will prevent parallel runs etc. Let me know your thoughts on this.
I have ofcourse tested this manually on linux/windows :)
Checklist
Reviewer Checklist