Refactor shared bundle action options #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Previously we had a shared option struct, sharedOptions and BundleAction, that were used for a large grouping of commands that work with bundles, from install to explain. I've refactored the shared options into more granular groupings so that later I can define debug mode for _just_ commands that run bundles. Now there are shared options for commands that execute bundles and commands that merely reference a bundle (such as explain). Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
refactor-bundle-action
branch
from
444fab4 to
d618364
Compare
VinozzZ
reviewed
Jul 20, 2022
Signed-off-by: Carolyn Van Slyck <[email protected]>
VinozzZ
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Previously we had a shared option struct, sharedOptions and BundleAction, that were used for a large grouping of commands that work with bundles, from install to explain.
I've refactored the shared options into more granular groupings so that later I can define debug mode for just commands that run bundles. Now there are shared options for commands that execute bundles and commands that merely reference a bundle (such as explain).
What issue does it fix
This is refactoring that will be used in upcoming changes such as #1430 and #1429 .
Notes for the reviewer
N/A
Checklist
Reviewer Checklist