Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace bundle.invocationImage with bundle.installerImage #2283

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Aug 3, 2022

What does this change

Template variable bundle.invocationImage has been deprecated and replaced with bundle.installerImage

This PR makes this update and make sure that installer image is always referencing to the current running image instead of the original image reference created during build time

What issue does it fix

Closes #1824
[1]: https://getporter.org/src/CONTRIBUTING.md#when-to-open-a-pull-request

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@VinozzZ VinozzZ marked this pull request as ready for review August 3, 2022 21:35
@VinozzZ VinozzZ requested review from carolynvs and vdice as code owners August 3, 2022 21:35
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is great. You just need to update the documentation page to use the new name of the template variable https://getporter.org/authors/templates/#bundle

Signed-off-by: Yingrong Zhao <[email protected]>
@VinozzZ VinozzZ requested a review from carolynvs August 8, 2022 16:28
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template variable bundle.invocationImage is incorrect
2 participants