Force push bundles #2331
Merged
Force push bundles #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
force-push-bundles
branch
from
6832d59 to
5e53782
Compare
Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
force-push-bundles
branch
2 times, most recently
from
e949399 to
1e472e7
Compare
When a bundle is pushed to a registry, check if the destination reference already exists and require that --force is specified to overwrite it. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
force-push-bundles
branch
from
1e472e7 to
119403b
Compare
Signed-off-by: Carolyn Van Slyck <[email protected]>
VinozzZ
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When a bundle is pushed to a registry, check if the destination reference already exists and require that --force is specified to overwrite it.
What issue does it fix
Close #2017
Notes for the reviewer
I have created #2337 to track coming up with a more robust/reliable system for comparing the contents of the local bundle to the remote bundle. It would be great if we can tell if they are the same, and not just ask them to repush with --force when it already matches.
Checklist
Reviewer Checklist