Split codeql from trivy #2449
Merged
Split codeql from trivy #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we upgraded from CodeQL v1 to v2, the performance of our "security scan" workflow went from 15m to over an hour, usually timing out. When CodeQL is initalized it replaces the go binary with their own custom one, and any builds done with it are included in the analysis. I have moved everything that doesn't need to be analyized to before initializing CodeQL, and also split out the cross-compilation required by Trivy (which scans our porter agent image) into a separate workflow. This way only the native builds for the porter client, runtime, exec mixin and agent are scanned by CodeQL. This has brought performance back to a tolerable level, about 12m again. Signed-off-by: Carolyn Van Slyck <[email protected]>
|
Trivy found existing alerts about the version of the docker cli we are using. We can't upgrade until Buildx works with recent versions of Docker, so we are pinned to a compatible version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we upgraded from CodeQL v1 to v2, the performance of our "security scan" workflow went from 15m to over an hour, usually timing out. When CodeQL is initialized it replaces the go binary with their own custom one, and any builds done with it are included in the analysis.
I have moved everything that doesn't need to be analyzed to before initializing CodeQL, and also split out the cross-compilation required by Trivy (which scans our porter agent image) into a separate workflow. This way only the native builds for the porter client, runtime, exec mixin and agent are scanned by CodeQL.
This has brought performance back to a tolerable level, about 12m again.