Handle custom invocation images without #PORTER_INIT #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation says that if the PORTER_INIT section is missing on the custom dockerfile, it will be placed right after the FROM section. This was not the case, instead it was place at the end of the file, resulting in a dockerfile not working with Porter Signed-off-by: Kim Christensen <[email protected]>
These tests was assertion that the resulting Dockerfile was generated with the bug fixed in the previous commit Signed-off-by: Kim Christensen <[email protected]>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
schristoff
reviewed
Feb 14, 2024
|
@schristoff Are there anything outstanding before this can be merged? |
schristoff
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
The documentation says that if the PORTER_INIT section is missing on the custom dockerfile, it will be placed right after the FROM section. This was not the case, instead it was place at the end of the file, resulting in a dockerfile not working with Porter.
What issue does it fix
Closes #2925
Notes for the reviewer
This could be considered a breaking chance, but it looks like the generated invocation image wouldn't work without this bug being fixed anyway. Also this change aligns with the documentation.
Checklist
Reviewer Checklist