Bundle script for Offline Installation of Porter #3205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcudd
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
There was a problem hiding this comment.
I do understand the change you are implementing here, but I'm a little concerned about the complexity it adds to the installation script.
Also preferably it should be implemented for the Powershell installation script.
Would it be possible for you to join the community meeting, so we can discuss the different options here? The next community meeting is on Thursday
* The plugin logger should use verbosity level The log level is meant to be used only for log files. Signed-off-by: Kim Christensen <[email protected]> * Correctly detect log level from plugin logs The constants used before was numbers, causing the writing to always fall back to writing as debug Signed-off-by: Kim Christensen <[email protected]> * Correct the documentation Signed-off-by: Kim Christensen <[email protected]> * Do not log information messages from the plugin infrastructure Signed-off-by: Kim Christensen <[email protected]> --------- Signed-off-by: Kim Christensen <[email protected]> Co-authored-by: schristoff <[email protected]> Signed-off-by: John Cudd <[email protected]>
Signed-off-by: John Cudd <[email protected]>
Signed-off-by: John Cudd <[email protected]>
Signed-off-by: John Cudd <[email protected]>
Signed-off-by: John Cudd <[email protected]>
Signed-off-by: John Cudd <[email protected]>
Signed-off-by: John Cudd <[email protected]>
Signed-off-by: John Cudd <[email protected]>
|
Closed in favor of #3210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Give a summary of the change, and how it affects end-users. It's okay to copy/paste your commit messages.
The new
bundle-linux.shscript automates the creation of a tarball containing all the necessary artifacts for installing the Porter CLI, including the MongoDB Docker image and the Porter installation files. It pulls a specific version of the MongoDB image and packages all the downloaded assets into a compressed tarball, providing clear instructions for extracting the bundle and executing the installation script. This makes it easy for users to set up Porter in air-gapped environments.The
install-linux.shscript has been updated to handle offline installations by installing local binaries and the MongoDB image if they are present. It now checks for the existence of themongo_image.tarfile, loads the MongoDB image into Docker, and runs a MongoDB container during installation if it is not already running. Additionally, the script allows the use of a localporter-linux-amd64binary if it is available, allowing for an fully offline installation.What issue does it fix
Closes #3198
Notes for the reviewer
The
bundle-linux.shscript pulls the latest version of theinstall-linux.shfrom the CDN, so when testing you will need to replace the downloadedinstall-linux.shfile with the one from this branch.Checklist