Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parameter set table output format #3314

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve parameter set table output format #3314

wants to merge 1 commit into from

Conversation

kichristensen
Copy link
Contributor

What does this change

  • Add "PARAMETER SET" column to distinguish between parameter set name and parameter name
  • Rename internal variable from paramsSets to result for clarity
  • Include parameter set name in output rows for better identification
  • Update table headers to reflect new column structure

What issue does it fix

Closes #3313

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@kichristensen
fix(parameters): improve parameter set table output format
1c8afb4 
- Add "PARAMETER SET" column to distinguish between parameter set name and parameter name
- Rename internal variable from paramsSets to result for clarity
- Include parameter set name in output rows for better identification
- Update table headers to reflect new column structure

Signed-off-by: Kim Christensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff Awaiting requested review from schristoff schristoff will be requested when the pull request is marked ready for review schristoff is a code owner

@sgettys sgettys Awaiting requested review from sgettys sgettys will be requested when the pull request is marked ready for review sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter will be requested when the pull request is marked ready for review bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 will be requested when the pull request is marked ready for review troy0820 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

porter parameters list doesn't show what parameter set the parameter belongs to
1 participant
@kichristensen