Explain allow-docker-host-access setting #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
doc-allow-docker-host-access
branch
2 times, most recently
from
7c59e25 to
1b21f9d
Compare
vdice
approved these changes
Mar 31, 2020
docs/content/configuration.md
Outdated
| The `PORTER_ALLOW_DOCKER_HOST_ACCESS` environment variable is not exposed as a | ||
| flag yet. | ||
|
|
||
| It controls whether or not the Docker host should be available to |
There was a problem hiding this comment.
Suggested change
| It controls whether or not the Docker host should be available to | |
| It controls whether or not the Docker host should be available for |
Update the configuration page with how to use the allow-docker-host-access setting as either an environment variable or configuration setting. It is not yet available as a command flag. Also note that based on how the Azure Cloud Shell driver is implemented today (using ACI as the host environment for running the porter commands such as porter install), this setting won't work yet in that environment.
carolynvs
force-pushed
the
doc-allow-docker-host-access
branch
from
1b21f9d to
e5e95eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Update the configuration page with how to use the
allow-docker-host-access setting as either an environment variable or
configuration setting. It is not yet available as a command flag.
Also note that based on how the Azure Cloud Shell driver is implemented
today (using ACI as the host environment for running the porter commands
such as porter install), this setting won't work yet in that
environment
https://deploy-preview-962--porter.netlify.com/configuration/#porter-allow-docker-host-access
What issue does it fix
Tidying up after #951
Notes for the reviewer
We will need some more follow-up issues to add best practices and examples. But this is limited to just how to use the new config.
Checklist