Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use porter v1 #31

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Use porter v1 #31

merged 2 commits into from
Jan 27, 2022

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Jan 10, 2022

These are the same changes I am applying to all the mixins:

  • Update to porter v1
  • Support ignoreError
  • Use mage instead of make
  • Use Go 1.17
  • Use simplified magefile targets

@carolynvs carolynvs force-pushed the use-mage branch 4 times, most recently from 436d695 to 844b53b Compare January 25, 2022 17:01

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
* Update to porter v1
* Support ignoreError
* Use mage instead of make
* Use Go 1.17
* Use simplified magefile targets

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs marked this pull request as ready for review January 25, 2022 17:46
@carolynvs carolynvs requested review from vdice and VinozzZ January 25, 2022 17:47
@carolynvs
Copy link
Member Author

This is ready to review now! 🎉

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Carolyn Van Slyck <[email protected]>

Co-authored-by: Vaughn Dice <[email protected]>
@carolynvs carolynvs merged commit 6261f95 into getporter:main Jan 27, 2022
@carolynvs carolynvs deleted the use-mage branch January 27, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants