Support authentication for the URL query runner. #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Feb 15, 2018
redash/query_runner/__init__.py
Outdated
| except Exception as exc: | ||
| # Catch any other exceptions, log it and reraise it. | ||
| logger.exception(exc) | ||
| raise sys.exc_info()[1], None, sys.exc_info()[2] |
There was a problem hiding this comment.
We have this block of code in some places, but it's not really needed. Any unhandled exception is being taken care of by the execute query task.
Adds a new BaseHTTPQueryRunner class and tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new BaseHTTPQueryRunner class and tests.
This is a backport from mozilla#336.