Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ARM64 runners instead of virtualization for ARM64 image builds #7291

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

lucydodo
Copy link
Member

@lucydodo lucydodo commented Jan 19, 2025

What type of PR is this?

  • Other

Description

A few days ago, GitHub launched a free-tier ARM64 runner for public repositories.
Currently, emulation was used to build ARM64 images, but by using the newly launched runner, we aim to improve speed.
In fact, a single test confirmed that the execution speed was 2 hours, 29 minutes, and 10 seconds faster. 🚀

How is this tested?

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Not applicable.

Any comments or review are welcome. Thank you.

@lucydodo lucydodo added the CI label Jan 19, 2025
@lucydodo lucydodo requested a review from Copilot January 19, 2025 00:45
@lucydodo lucydodo self-assigned this Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (10ce280) to head (c440a69).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7291   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         163      163           
  Lines       13410    13410           
  Branches     1905     1905           
=======================================
  Hits         8585     8585           
  Misses       4490     4490           
  Partials      335      335           

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, lets try it out. 😄

@justinclift justinclift merged commit 8c58904 into getredash:master Jan 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants