Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7272: Error in rehash DB migration with Elasticsearch queries #7292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wm3
Copy link

@wm3 wm3 commented Jan 21, 2025

What type of PR is this?

  • Bug Fix

Description

When migrating from Redash 10.1.0 to 25.1.0, the initialization of the Elasticsearch query runner is triggered, causing an error to be thrown. In addition to the measures implemented in #7258, the current fix ensures that the migration proceeds successfully.

How is this tested?

  • Manually

The same issue as #7272 occurred in the current environment. After applying this fix, running docker-compose run --rm server manage db upgrade completed the migration successfully, and it was confirmed that Elasticsearch queries can now be executed.

Related Tickets & Documents

@eradman eradman enabled auto-merge (squash) January 21, 2025 14:46
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.01%. Comparing base (10ce280) to head (e20fac0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
redash/query_runner/elasticsearch.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7292   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         163      163           
  Lines       13410    13410           
  Branches     1905     1905           
=======================================
  Hits         8585     8585           
  Misses       4490     4490           
  Partials      335      335           
Files with missing lines Coverage Δ
redash/query_runner/elasticsearch.py 15.46% <0.00%> (ø)

@wm3
Copy link
Author

wm3 commented Jan 22, 2025

@eradman
It seems that an error is occurring in the coverage. Is it necessary to add additional tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant