Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'working-directory' argument for action-release #117

Closed
tyree731 opened this issue Nov 30, 2022 · 2 comments
Closed

Implement 'working-directory' argument for action-release #117

tyree731 opened this issue Nov 30, 2022 · 2 comments

Comments

@tyree731
Copy link
Contributor

When running the action-release Github Action, occasionally one might need to perform auto-detection of associated commits in a directory other than the job's working directory, such as in the case where an action performs multiple checkouts. As Github Actions do not, by default, support the ability to run an action in any directory other than the job's working directory, it would be great if action-release could support a working-directory argument for specifying where to detect commit information.

@tyree731
Copy link
Contributor Author

tyree731 commented Dec 8, 2022

I put up a possible change which I believe implements the functionality here. I considered adding this to the sentry/cli package itself, but that package already reads in from places such as the environment, and has no builtin notion of the directory to grab releases from, so it seemed fine to chdir from here.

@tyree731
Copy link
Contributor Author

Pull request implementing this has been merged. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant