feat: implement 'working-directory' argument #120
Conversation
|
@tyree731 Thanks for the PR! The original authors are not around. Would you be able to test that the action works as you expect it to? |
When running the action-release Github Action, occasionally one might need to perform auto-detection of associated commits in a directory other than the job's working directory, such as in the case where an action performs multiple checkouts. As Github Actions do not, by default, support the ability to run an action in any directory other than the job's working directory, this change implements an argument for specifying which directory to gather sentry release information from.
|
My github actions testing foo is weak so I accidentally closed this. I tested this here: And the existing tests work (with slight modification from my original change). For testing this with my change, would you like me to make another test that works off a subdirectory? |
No worries
Yes, please! That would be great! |
|
Hey @armenzg , I added a test which probably works for testing this. Can you please enable running workflows for me? Thanks! |
|
Ok, now I've got a working run: https://github.com/tyree731/action-release/actions/runs/3677213354 |
|
Will this get merged? |
|
I added it to my to-do to look at this week. My apologies on the delay. |
|
Hi, sorry, lost track of this one. So, should I add the README before this gets merged? |
|
Went ahead and added the README changes needed here. Let me know if there is anything else I need to do. Thanks! |
|
@armenzg hi. Anything else I need to do here, or are we good to get this merged? |
When running the action-release Github Action, occasionally one might need to perform auto-detection of associated commits in a directory other than the job's working directory, such as in the case where an action performs multiple checkouts. As Github Actions do not, by default, support the ability to run an action in any directory other than the job's working directory, this change implements an argument for specifying which directory to gather sentry release information from.
Implements #117 .