Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix unzipping larger files in node 18+ #524

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Mar 13, 2024

details here: #511 (comment)

failure mode in node 18+ on linux:

FAIL src/utils/__tests__/system.test.ts
  ● extractZipArchive › it can extract a larger zip
    expect(received).toBe(expected) // Object.is equality
    Expected: "7687e11d941faf48d4cf[16](https://github.com/getsentry/craft/actions/runs/8270883320/job/22629429489?pr=524#step:6:17)92c2473a599ad0d7030e1e5c639a31b2f59cd646ba"
    Received: "223cbd594b6294f4dd79864a259b1806776e10633519f0afd05209f88a87c98d"
      195 |             // should not have corrupted our file
      196 |             const checksum = await calculateChecksum(`${tmpdir}/out/t.txt`);
    > 197 |             expect(checksum).toBe('7687e11d941faf48d4cf1692c2473a599ad0d7030e1e5c639a31b2f59cd646ba');
          |                              ^
      198 |         });
      199 |     });
      200 | });
      at src/utils/__tests__/system.test.ts:197:30
      at withTempDir (src/utils/files.ts:83:12)
      at Object.<anonymous> (src/utils/__tests__/system.test.ts:[18](https://github.com/getsentry/craft/actions/runs/8270883320/job/22629429489?pr=524#step:6:19)2:9)

@asottile-sentry asottile-sentry changed the title ref: add regression test for unzipping larger file in node 18+ ref: fix unzipping larger files in node 18+ Mar 13, 2024
@asottile-sentry asottile-sentry force-pushed the asottile-unzip-larger-file-node-18 branch from 6f70f50 to c620833 Compare March 13, 2024 20:06
@asottile-sentry asottile-sentry force-pushed the asottile-unzip-larger-file-node-18 branch from f787cd5 to d920e1c Compare March 13, 2024 20:14
@asottile-sentry asottile-sentry marked this pull request as ready for review March 13, 2024 20:15
@asottile-sentry asottile-sentry requested a review from a team March 13, 2024 20:16
@asottile-sentry asottile-sentry merged commit b22cfa5 into master Mar 14, 2024
10 checks passed
@asottile-sentry asottile-sentry deleted the asottile-unzip-larger-file-node-18 branch March 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants