ref(docker): Use docker buildx (BuildKit) to publish docker images #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/docker-buildx
branch
from
2d1a890 to
15f20bd
Compare
|
Not easy to test craft ... but it works! The uploaded image: The publish output: And the used changelogPolicy: none
statusProvider:
name: github
artifactProvider:
name: none
targets:
- id: release
name: docker
source: ghcr.io/getsentry/relay
sourceFormat: "{{{source}}}:d8e6bbc4e32d7b7d56c3ea6e5d8cecf281e1ab99"
target: dav1d/relay |
Dav1dde
force-pushed
the
dav1d/docker-buildx
branch
from
15f20bd to
4f45ee3
Compare
src/targets/docker.ts
Outdated
| await this.pull(revision); | ||
| await this.push(revision, version); | ||
|
|
||
| if (await this.hasBuildKit()) { |
There was a problem hiding this comment.
I'm inclined to just require buildkit and clean up the old code -- it's been around for half a decade
There was a problem hiding this comment.
Unfortunately that will fail on OSX, at least it does on my colima install.
There was a problem hiding this comment.
what does docker version give you? I'd be pretty surprised if it's older than 2017
There was a problem hiding this comment.
└─ % docker version
Client: Docker Engine - Community
Version: 27.0.3
API version: 1.43 (downgraded from 1.46)
Go version: go1.22.4
Git commit: 7d4bcd863a
Built: Fri Jun 28 14:56:30 2024
OS/Arch: darwin/arm64
Context: colima
Server:
Engine:
Version: 24.0.5
API version: 1.43 (minimum version 1.12)
Go version: go1.20.7
Git commit: 24.0.5-0ubuntu1
Built: Wed Aug 16 21:32:36 2023
OS/Arch: linux/arm64
Experimental: false
containerd:
Version: 1.7.2
GitCommit:
runc:
Version: 1.1.7-0ubuntu2.2
GitCommit:
docker-init:
Version: 0.19.0
GitCommit:
└─ % docker buildx version
docker: 'buildx' is not a docker command.
See 'docker --help'
There was a problem hiding this comment.
on macos you'll need the docker-buildx package (it's a plugin -- that's usually shipped with core but is separate for some reason there)
There was a problem hiding this comment.
Ah yeah it's installable, but it means the change will become breaking even for current docker installs. I am totally fine with that though.
Let me know if you want me to change the code and drop the old pull/push method.
There was a problem hiding this comment.
yeah I think it's reasonable -- arguably the non-buildx behaviour is broken
Dav1dde
changed the title
asottile-sentry
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When availableUses docker buildkit to copy images, this also handles multi arch images correctly. Docker publishes without buildkit installed will fail now.Fixes: #541