test(utils): Add additional tests for version helper functions #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile-sentry
approved these changes
Nov 11, 2024
| major: 1, | ||
| minor: 2, | ||
| patch: 3, | ||
| pre: '1', |
There was a problem hiding this comment.
might be worth a comment that it misinterprets this -- but it's ok as long as we don't utilize this function for python in the same way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests for version helper functions used in multiple craft targets.
This came up after investigating getsentry/sentry-docs#11716 where I found out that we have a specific list of pre-release suffix identifiers that we consider a pre-release, instead of considering every
-xstring after the patch number a pre-release.Specifically, as mentioned in #561 (comment), we don't consider the (shorthand) python post release pattern (TIL) a pre-release, although
parseVersionactually puts it into the returned.preproperty.Tests added:
parseVersionparses Python post release valuesisValidVersionreturnstruefor Python post releasesisPreviewVersionreturnsfalsefor Python post releasesisPreviewVersionreturningtruefor allowed identifiersI don't have strong feelings on getting this merged, so feel free to reject it but I figured I might as well open a PR after having added these tests locally.