Update from upstream 2022-10-17 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty arrays aren't allowed in C/C++, so we advise callers to pass nullptr instead. Change-Id: If6724fa5a8b657207337df8b36fa2b3b4fddd955 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3894498 Reviewed-by: Ben Hamilton <[email protected]> Commit-Queue: Alan Zhao <[email protected]>
This file only applies to python 2 and is no longer valid. Bug: 1336295 Change-Id: I55e56275250f28fb7fbe3a2423b934f678c34fa9 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3900797 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]> Commit-Queue: Fabrice de Gans <[email protected]>
…essingPendingReports() Previously, StartProcessingPendingReports() only started the prune and upload threads if it thought the application was actively running in the foreground. However, some Crashpad clients would like to replicate Breakpad's behavior of allowing uploads while the application is starting up (before it moves to the foreground). This CL introdues an optional UploadBehavior enum to InProcessHandler::StartProcessingPendingReports(), defaulting to the current behavior of only uploading processed crash reports while the application is in the foreground. If the enum is set to UploadBehavior::kUploadImmediately, then InProcessHandler will start the prune and upload threads regardless of the application state. (If the application state later transitions to a non-active state, then InProcessHandler will stop the prune and upload threads as normal.) Change-Id: I4f13f3a3006d636dd3e511b21ccc23a90b2ea639 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3894230 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Justin Cohen <[email protected]>
SDK definition of WER_RUNTIME_EXCEPTION_INFORMATION changed in SDK 19041 to add the bIsFatal field which we use. This adds a local definition of the newer structure to allow the WER handler to build on earlier SDKs. Bug: crashpad:423 Change-Id: I23bb69cc002ac8d469227e549f29b0af4849c893 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3880663 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Alex Gough <[email protected]>
These were suggested after https://crrev.com/c/3864248 was submitted. Change-Id: I73c451a3ea52721d8476e229cff7a0aded6746ac Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3902210 Commit-Queue: Alan Zhao <[email protected]> Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
GCC 12 does not allow it in C++20 mode anymore. Bug: chromium:819294 Change-Id: I025dda8046739fefc4ff449d4496ef496374eff5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3929186 Commit-Queue: Mark Mentovai <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
There's a new try_free_default in malloc zone 13, and tests now need to replace zone functions in all zones, not just the default zone. Change-Id: I5a9893a73f8c9f7068e52bf25f57632f9e409aa2 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3934555 Reviewed-by: Joshua Peraza <[email protected]> Commit-Queue: Justin Cohen <[email protected]>
From https://chromium-review.googlesource.com/c/3936784/1/third_party/crashpad/crashpad/third_party/edo/BUILD.gn. Bug: chromium:1098010 Change-Id: Ia18db07d4d9be43c0dae5eb84d91dd68531a75e3 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3938565 Commit-Queue: Mark Mentovai <[email protected]> Reviewed-by: Joshua Peraza <[email protected]>
|
@Swatinem review ping :) |
Swatinem
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this contains a runtime-fix for the Win10 build 10941 compatibility topic (#70), I would leave our build-time exclusion of the WER module in there.