This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
feat(github-apps): Do not fail immediately on missing GitHub contexts #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes GitHub doesn't update commit status contexts in time (e.g. for Travis, or Azure Pipelines), and Freight deploys fail because of that. In particular, it may hurt if we deploy something automatically after a push to master.
This change relaxes the check a bit: Freight now retries the github-app check if some contexts are missing on the first check.
Not super happy with this. Inside the check code we don't have access to the deploy identifier, and we also run checks outside the deploy context when we start new builds via the UI. This basically means that we'll still get the "No contexts were present" error in some cases.
Open to suggestions on how to improve this.