fix(projects): Treat fetch failures as pending #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Oct 15, 2024
| time.sleep(1) # Wait for project to be cached | ||
|
|
||
| # Relay still accepts events for this project | ||
| next_response = relay.send_event(42) |
There was a problem hiding this comment.
With the old version, this call raises a 403 error.
Dav1dde
approved these changes
Oct 15, 2024
Good point, we should alert when the buffer gets close to its total capacity, or implement @iambriccardo 's automatic eviction policy. I added a task to the epic. |
loewenheim
approved these changes
Oct 15, 2024
|
Note: not merging this until https://github.com/getsentry/team-ingest/issues/345 is mature. |
jjbayer
added a commit
that referenced
this pull request
Oct 15, 2024
Measure impact before we merge #4140.
jjbayer
force-pushed
the
fix/project-failure-is-pending
branch
from
688d23e to
2970ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fail to fetch a project state for any reason (max retries exceeded, redis error), we should not mark the project as invalid.
Currently we treat the project as if the DSN was invalid, and respond to clients with a 403 response. This might have made sense as a defensive measure in a pre-spooling world where envelopes could not be buffered for a longer period of time, but with spooling and time-based envelope eviction, we can now safely buffer them.
ref: INC-888
blocked by: https://github.com/getsentry/team-ingest/issues/345