fix: Don't propagate sampled traces #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
commented
Nov 19, 2024
Comment on lines
+298
to
+305
| let traces_sample_rate = config.traces_sample_rate; | ||
| // We're explicitly setting a `traces_sampler` here to circumvent trace | ||
| // propagation. A trace sampler that always just returns the constant | ||
| // `traces_sample_rate` is equivalent to using the `traces_sample_rate` | ||
| // directly, except it doesn't take into account whether the context | ||
| // was previously sampled. We don't want to take that into account because | ||
| // SDKs send headers with their envelopes that erroneously cause us to | ||
| // sample transactions. |
There was a problem hiding this comment.
Please let me know if this comment doesn't explain the problem correctly or clearly enough.
Dav1dde
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/getsentry/team-ingest/issues/587.